This repository has been archived by the owner on May 3, 2024. It is now read-only.
CORTX-30753: Codacy code cleanup(#1608) #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfhad
requested review from
mehjoshi,
madhavemuri,
nikitadanilov,
yeshpal-jain-seagate,
huanghua78,
andriytk,
siningwuseagate,
vidyadhar-pinglikar,
shashank-parulekar,
nkommuri,
sg-shankar,
ivan-alekhin and
sergey-shilov
as code owners
|
Can one of the admins verify this patch? |
|
ok to test |
r-wambui
added
rose
Status: Waiting to be Reviewed
|
This issue/pull request has been marked as |
This patch fixes some of the codacy warnings. Warning fixed: "SC2006: Use $(...) notation instead of legacy backticked `...`" Signed-off-by: alfhad <fahadshah2411@gmail.com>
alfhad
force-pushed
the
issue-1608-v2
branch
from
e209283
to
6626972
Compare
huanghua78
approved these changes
Sep 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes some of the codacy warnings.
Warning fixed: "SC2006: Use $(...) notation instead of legacy backticked
..."Signed-off-by: alfhad fahadshah2411@gmail.com
Problem Statement
We see 369 occurrence of pattern, "Use$(...) notation instead of legacy backticked ....".
Design
Replaced the backticked with "$(...)"
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author